Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update cli package used for patch generation #8209

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mikehardy
Copy link
Collaborator

Description

Noticed on latest PR that the patch-package generation failed, due to a deprecation

npx react-native init deprecated, npx @react-native-community/cli init current

Release Summary

One conventional commit, rebase merge should be fine, will not trigger a release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Very difficult to test workflows.

This should either work though, or will at worst need a slight tweak and a force-push with the tweak to accept the temp install of the package non-interactively


Think react-native-firebase is great? Please consider supporting the project with any of the below:

`npx react-native init` deprecated, `npx @react-native-community/cli init` current
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:35pm

@mikehardy
Copy link
Collaborator Author

Success, that fixed it, the relevant check already completed:

https://github.com/invertase/react-native-firebase/actions/runs/12587037704/job/35082074850?pr=8209

@mikehardy mikehardy merged commit c48ca9e into main Jan 2, 2025
18 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/change-patches-cli-usage branch January 2, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant