docs: create a Swift version example of the ios-notification-images doc #8185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
petetnt
commented
Dec 11, 2024
|
|
||
| ```diff | ||
| import UserNotifications | ||
| + import Firebase |
There was a problem hiding this comment.
Not 100% sure why the import here is Firebase instead of FirebaseMessaging - by following the steps in the doc, only Firebase is available.
|
fixed trivial lint issue and re-pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is sort of follow up for #8184. This PR adds Swift version of the same steps described in the document so others don't have to convert the example steps manually like I did.
Release Summary
docs: added a Swift version example of the
ios-notification-images.mddocChecklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Run the steps in the doc, build the app, check that the image shows up