fix: typing for firestore orderBy
#7570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to fix #7147
Taking
string
type from@google-cloud/firestore
types: https://github.com/googleapis/nodejs-firestore/blob/22ac90f0a043e493f89834604bd249f69c5dc036/types/firestore.d.ts#L1719Also the same on
firebase-js-sdk
:https://github.com/firebase/firebase-js-sdk/blob/991fa271c867d59e2bed44c69c0512fdeb54bbb4/packages/firestore/src/lite-api/query.ts#L478
and the documentation for the
firebase-js-sdk
:https://github.com/firebase/firebase-js-sdk/blob/991fa271c867d59e2bed44c69c0512fdeb54bbb4/common/api-review/firestore.api.md?plain=1#L473