Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing for firestore orderBy #7570

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: typing for firestore orderBy #7570

merged 1 commit into from
Jan 23, 2024

Conversation

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 6:21am
react-native-firebase-next ❌ Failed (Inspect) Jan 15, 2024 6:21am

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like just the thing @ChromeQ - thank you!
Thanks especially for the links to the upstream refs, makes it much easier to hit the merge button

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jan 23, 2024
@mikehardy mikehardy merged commit 1ea166a into invertase:main Jan 23, 2024
15 of 17 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jan 23, 2024
@ChromeQ ChromeQ deleted the patch-1 branch January 25, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] 🔥Firestore collection orderBy string type is incorrect when using interface
3 participants