Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, sdk): adopt firebase-android-sdk 32.4.0 #7413

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

mikehardy
Copy link
Collaborator

Description

Bump of firebase-android-sdk, nothing to change at the user level that I'm aware of

Related issues

I want to stage this after a release of #7412 since that one is pretty critical and I'm having bad luck recently with new upstream SDK versions - don't want to have something critical for users released after something that may not work, meaning people won't be able to rollback without losing the critical fix...

Release Summary

there is only conventional commits, this is the way

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

local e2e test runs, CI will run it as well


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Oct 20, 2023
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 9:38pm
react-native-firebase-next ❌ Failed (Inspect) Oct 20, 2023 9:38pm

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #7413 (7bd854c) into main (2d8ac14) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7413   +/-   ##
=========================================
  Coverage     54.12%   54.12%           
  Complexity      738      738           
=========================================
  Files           248      248           
  Lines         12163    12163           
  Branches       1897     1897           
=========================================
  Hits           6582     6582           
  Misses         5235     5235           
  Partials        346      346           

@mikehardy mikehardy merged commit 63f1893 into main Oct 21, 2023
16 checks passed
@mikehardy mikehardy deleted the @mikehardy/android-sdk-32.4.0 branch October 21, 2023 02:10
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant