Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, expo): use modern import style, required by Expo 44+ #6126

Merged
merged 1 commit into from
Mar 13, 2022

Conversation

mikehardy
Copy link
Collaborator

Description

Expo 44+ enforces use of new import style for React headers, and they
are supported far enough back in time on react-native versions this should
not be breaking for anyone

Related issues

Fixes #5965

Release Summary

single commit, it's conventionsl

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

It's an iOS import style change, either it compiles or it does not. Compiles in local testing, e2e will check as well of course


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Expo 44+ enforces use of new import style for React headers, and they
are supported far enough back in time on react-native versions this should
not be breaking for anyone
@vercel
Copy link

vercel bot commented Mar 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/4FBCmXyC96NtspxiuvqcCQFpyRu2
✅ Preview: https://react-native-firebase-git-mikehardy-expo44-compat-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/BguJK3HxFrvhZDdYoWDM7J9LgVXx
✅ Preview: Canceled

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Mar 13, 2022
@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #6126 (fe6d223) into main (1fe6ac7) will not change coverage.
The diff coverage is n/a.

❗ Current head fe6d223 differs from pull request most recent head 64f3999. Consider uploading reports for the commit 64f3999 to get more accurate results

@@            Coverage Diff            @@
##               main    #6126   +/-   ##
=========================================
  Coverage     52.92%   52.92%           
  Complexity      622      622           
=========================================
  Files           208      208           
  Lines         10220    10220           
  Branches       1626     1626           
=========================================
  Hits           5408     5408           
  Misses         4558     4558           
  Partials        254      254           

@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Mar 13, 2022
@mikehardy mikehardy merged commit 4060827 into main Mar 13, 2022
@mikehardy mikehardy deleted the @mikehardy/expo44-compat branch March 13, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] 🔥 [iOS][Expo/SDK44] Generated RNFBApp/RNFBVersion.m uses old style react header imports
1 participant