-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added ignore build step for next deployments #5515
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/Hx4Vbd8MJhCt2yDsfs7sMAj3CZKk react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/4w1uJg9Y9HqCJYBK8MfAQaq7CM5s [Deployment for 3cb7677 failed] |
Codecov Report
@@ Coverage Diff @@
## master #5515 +/- ##
=============================================
- Coverage 80.11% 67.47% -12.63%
- Complexity 0 980 +980
=============================================
Files 109 189 +80
Lines 4137 9523 +5386
Branches 439 1487 +1048
=============================================
+ Hits 3314 6425 +3111
- Misses 752 2686 +1934
- Partials 71 412 +341 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure the idea in general is useful for your vNext work and I like both the idea and the implementation. So then I pictured a future frame of reference where it was maybe in the wee hours of the morning and I was trying to decipher why a build was (or was) not doing what I wanted, and proposed altered wording to give my future exhausted self more explicit breadcrumbs in the logs just in case. What do you think?
Co-authored-by: Mike Hardy <[email protected]>
Co-authored-by: Mike Hardy <[email protected]>
Agreed! I really did think there used to be a different way of doing this. This should only be necessary while developing the new modules in parallel, once that branch is merged we can simply delete the file. The Vercel config for this is restricted to the preview deployment only! ie. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is ready in the vercel config, this LGTM - hit that merge button :-)
⚡ |
Description
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter