Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added ignore build step for next deployments #5515

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

dackers86
Copy link
Member

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jul 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/Hx4Vbd8MJhCt2yDsfs7sMAj3CZKk
✅ Preview: https://react-native-firebase-git-invertase-manage-nex-1f0cd7-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/4w1uJg9Y9HqCJYBK8MfAQaq7CM5s
✅ Preview: Failed

[Deployment for 3cb7677 failed]

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #5515 (a2ab130) into master (3b48240) will decrease coverage by 12.64%.
The diff coverage is 82.90%.

❗ Current head a2ab130 differs from pull request most recent head 3cb7677. Consider uploading reports for the commit 3cb7677 to get more accurate results

@@              Coverage Diff              @@
##             master    #5515       +/-   ##
=============================================
- Coverage     80.11%   67.47%   -12.63%     
- Complexity        0      980      +980     
=============================================
  Files           109      189       +80     
  Lines          4137     9523     +5386     
  Branches        439     1487     +1048     
=============================================
+ Hits           3314     6425     +3111     
- Misses          752     2686     +1934     
- Partials         71      412      +341     

@dackers86 dackers86 changed the title Added ignore build step for next deployments Chore: Added ignore build step for next deployments Jul 13, 2021
@dackers86 dackers86 changed the title Chore: Added ignore build step for next deployments chore: Added ignore build step for next deployments Jul 13, 2021
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure the idea in general is useful for your vNext work and I like both the idea and the implementation. So then I pictured a future frame of reference where it was maybe in the wee hours of the morning and I was trying to decipher why a build was (or was) not doing what I wanted, and proposed altered wording to give my future exhausted self more explicit breadcrumbs in the logs just in case. What do you think?

script.sh Outdated Show resolved Hide resolved
script.sh Outdated Show resolved Hide resolved
Co-authored-by: Mike Hardy <[email protected]>
Co-authored-by: Mike Hardy <[email protected]>
@dackers86
Copy link
Member Author

I'm sure the idea in general is useful for your vNext work and I like both the idea and the implementation. So then I pictured a future frame of reference where it was maybe in the wee hours of the morning and I was trying to decipher why a build was (or was) not doing what I wanted, and proposed altered wording to give my future exhausted self more explicit breadcrumbs in the logs just in case. What do you think?

Agreed! I really did think there used to be a different way of doing this. This should only be necessary while developing the new modules in parallel, once that branch is merged we can simply delete the file. The Vercel config for this is restricted to the preview deployment only! ie. react-native-firebase-next

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ready in the vercel config, this LGTM - hit that merge button :-)

@dackers86
Copy link
Member Author

Setting updated.

image

@mikehardy mikehardy merged commit f47a7c7 into master Jul 16, 2021
@mikehardy mikehardy deleted the @invertase/manage-next-deployments-script branch July 16, 2021 16:41
@mikehardy
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants