Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): de-flake tests #5323

Merged
merged 3 commits into from
May 17, 2021
Merged

test(e2e): de-flake tests #5323

merged 3 commits into from
May 17, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

Always trying to have more testing and more reliable testing...

Related issues

Related #4058

Release Summary

conventional commits - rebase merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Nothing but tests


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/BzsHGCX3uZFew2c1EEMZbugDNziJ
✅ Preview: https://react-native-firebase-git-mikehardy-de-flake-20210516-invertase.vercel.app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #5323 (082f4c4) into master (5e30592) will increase coverage by 6.84%.
The diff coverage is n/a.

❗ Current head 082f4c4 differs from pull request most recent head fa95460. Consider uploading reports for the commit fa95460 to get more accurate results

@@             Coverage Diff              @@
##             master    #5323      +/-   ##
============================================
+ Coverage     68.75%   75.59%   +6.84%     
============================================
  Files           189       96      -93     
  Lines          9419     4218    -5201     
  Branches       1411      845     -566     
============================================
- Hits           6475     3188    -3287     
+ Misses         2532      961    -1571     
+ Partials        412       69     -343     

@mikehardy mikehardy force-pushed the @mikehardy/de-flake-20210516 branch from 020a157 to fa95460 Compare May 17, 2021 05:56
@mikehardy mikehardy merged commit 7a4f78e into master May 17, 2021
@mikehardy mikehardy deleted the @mikehardy/de-flake-20210516 branch May 17, 2021 07:43
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant