-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app, android): support list of Activities to ignore when detecting AppState #5235
feat(app, android): support list of Activities to ignore when detecting AppState #5235
Conversation
…e/common/SharedUtils.java Co-authored-by: Mike Hardy <[email protected]>
…e/common/SharedUtils.java Co-authored-by: Mike Hardy <[email protected]>
…e/common/SharedUtils.java Co-authored-by: Mike Hardy <[email protected]>
…e/common/SharedUtils.java Co-authored-by: Mike Hardy <[email protected]>
Co-authored-by: Mike Hardy <[email protected]>
Co-authored-by: Mike Hardy <[email protected]>
…e/common/ReactNativeFirebaseJSON.java Co-authored-by: Mike Hardy <[email protected]>
…e/common/SharedUtils.java Co-authored-by: Mike Hardy <[email protected]>
…e/common/SharedUtils.java Co-authored-by: Mike Hardy <[email protected]>
Co-authored-by: Mike Hardy <[email protected]>
…e/common/SharedUtils.java Co-authored-by: Mike Hardy <[email protected]>
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/DcanRUBryKUjLhmALjrLixEWB6Gb |
Codecov Report
@@ Coverage Diff @@
## master #5235 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 109 109
Lines 3743 3743
Branches 360 360
=======================================
Hits 3326 3326
Misses 370 370
Partials 47 47 |
lint check addition for NewApi saved the day on this one, I did not see it until CI failed
…ng AppState (invertase#5235) * Check json config for background activities * Add json config key to test app to exercise code Co-authored-by: Mike Hardy <[email protected]> Co-authored-by: Dan White <[email protected]>
Description
This is entirely based off the good work from @danwhite-ipc on #5228 - just doing a branch here so I can push one final change to it - I don't have write powers on that branch
From that PR:
Related issues
Supercedes #5228 but verified the CLA was signed.
Fixes #5219
Release Summary
PR title is conventional, squash merge
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Relying on @danwhite-ipc to indicate it works for them :-), I added a test array key to the test app firebase.json and it gets a background message during E2E testing, so that should at least exercise the JSON parse code
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter