-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf): support "perf_auto_collection_enabled" flag in firebase.json #4870
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/dfu7b17qf |
Codecov Report
@@ Coverage Diff @@
## master #4870 +/- ##
=======================================
Coverage 89.09% 89.09%
=======================================
Files 109 109
Lines 3718 3718
Branches 347 347
=======================================
Hits 3312 3312
Misses 364 364
Partials 42 42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks in general fantastic, thank you!
I had one change I propose - with a question attached - that I'd like your feedback on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thank you!
I'm a little bit back-logged on publishing a new version but 10.6.0 with this change in it should release "really soon now" (a day? three? less than a week)
All good. We'll use a workaround until it's ready. Thanks for the quick review! |
I had a moment and fixed the bottleneck problem #4708 and got 10.6.1 out with all peerDependencies between the modules correct and everything 😅 - good to go! |
Description
More or less clones 9a24ecd
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Checking that firebase performance is disabled on app start when this flag is set.