-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app, android): remove firebase-core from dependencies #4597
fix(app, android): remove firebase-core from dependencies #4597
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/cq2irg8l7 [Deployment for 6873d39 failed] |
Codecov Report
@@ Coverage Diff @@
## master #4597 +/- ##
=======================================
Coverage 88.98% 88.98%
=======================================
Files 109 109
Lines 3710 3710
Branches 346 346
=======================================
Hits 3301 3301
Misses 368 368
Partials 41 41 |
83362aa
to
6873d39
Compare
Fantastic, thanks for this! The Vercel CI failure is unrelated, it should resolve when merged, but either way won't block this, and the other main CI jobs (android + ios E2E) have already passed the point they would have failed with this We will need the CLA signed (just follow the details link on the CI check for it) in order to merge, but it's a 5 second job Noted from the linked issue as well as here: thanks for testing this locally, that plus the CI here gives me confidence that it's going to work. It's a semi-fundamental change but that also means it should have failed fast with at least one of the tests you and CI have done Cheers |
@mikehardy Thanks for the instruction, the CLA is signed. |
Description
According to the firebase release notes, the
firebase-core
for Android is no longer needed.Related issues
Fixes #4593
Release Summary
Remove firebase-core from Android dependencies.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
tests:android:build
@react-native-firebase/analytics
@react-native-firebase/app
@react-native-firebase/crashlytics
@react-native-firebase/messaging
@react-native-firebase/perf
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter