chore(sdks, tests): update SDKs / Fix tests compile for xcode12 #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/cnnr7839o |
mikehardy
added
the
Workflow: Needs Review
8 tasks
mikehardy
changed the title
mikehardy
force-pushed
the
tests-xcode12
branch
from
ac42647 to
efca39d
Compare
Codecov Report
@@ Coverage Diff @@
## master #4401 +/- ##
=======================================
Coverage 67.05% 67.05%
=======================================
Files 114 114
Lines 3820 3820
Branches 278 278
=======================================
Hits 2561 2561
Misses 1150 1150
Partials 109 109 |
|
Yeah, so still some work to do https://github.com/invertase/react-native-firebase/runs/1262569666#step:15:11 Might be that the .github workflow taking a bump to Xcode12 would fix it, I'll try that next [edit: trying Xcode12 now, pushed the change and it's building...] |
Upgrade firebase sdk version to 25.12.0 to fix [issue invertase#4189](invertase#4189)
Co-authored-by: Mike Hardy <[email protected]>
Without these, there are linker failures as Xcode12 attempts to build for all archs, even when it's not really possible
This should fix invertase#4397
mikehardy
force-pushed
the
tests-xcode12
branch
from
efca39d to
c8f1b8f
Compare
mikehardy
added
Workflow: Needs Second Review
|
All working now! My default action will be to merge this before end of day in order to unblock RNFB development but I'll wait that long in case anyone has comments / wisdom about the changes |
mikehardy
removed
the
Workflow: Needs Second Review
6 tasks
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this pull request
Aug 9, 2021
…rtase#4401) * Upgrade firebase sdk version Upgrade firebase sdk version to 25.12.0 to fix [issue invertase#4189](invertase#4189) * Update iid android library Co-authored-by: Mike Hardy <[email protected]> * update sdk for ios firebase, iid and playServicesAuth * update firebase bom version * Update FirebaseSDKVersion * Install firebase-tools as dev dep in tests, reference locally * De-integrate pre-compiled firestore, incompatible with Xcode12+detox invertase/firestore-ios-sdk-frameworks#15 * Exclude arm64/i386 from simulator build archs for Xcode12 compatibility Without these, there are linker failures as Xcode12 attempts to build for all archs, even when it's not really possible * Workaround upstream MLKit dependency-related compile failures https://firebase.google.com/support/release-notes/android#mlkit-self-serve-fixes firebase/firebase-android-sdk#1904 * Use Xcode "latest-stable" (12 now) in E2E CI This should fix invertase#4397 Co-authored-by: Mujtaba F. Radhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is based on the good work from @MujtabaFR
They got the underlying SDK up to the point we noticed Android failures.
Turns out if you take MLKit past SDK BOM 25.7.0 you have incompatibilities you need to work around:
firebase/firebase-android-sdk#1904
https://firebase.google.com/support/release-notes/android#mlkit-self-serve-fixes
So I applied the necessary changes
In the process I tested ios and realized we don't work well with Xcode 12 (#4397) so I applied the necessary workarounds there
This now passes tests on local machine for android and ios and will hopefully go through e2e
@Salakar I'd especially like a look at this specific commit: 4f74c17 - I'm not 100% sure on it and it will fail in the future with Apple Silicon - you may have handled this elsewhere already?
Related issues
#4397 - Xcode 12 issue here
#4388 - PR that is the base for this
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter