Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, messaging): register background handler task #4180

Merged
merged 2 commits into from
Aug 31, 2020
Merged

fix(ios, messaging): register background handler task #4180

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
725e2e3
Minor fix to handle notifications in background state, now we are reg…
davx1992 Aug 31, 2020
fbebde6
Apply suggestions from code review
mikehardy Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/messaging/ios/RNFBMessaging/RNFBMessaging+AppDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,22 @@ - (void)application:(UIApplication *)application didReceiveRemoteNotification:(N

if (userInfo[@"gcm.message_id"]) {
if ([UIApplication sharedApplication].applicationState == UIApplicationStateBackground) {
//If app is in background state, register background task
mikehardy marked this conversation as resolved.
Show resolved Hide resolved
UIBackgroundTaskIdentifier __block backgroundTaskId = [application beginBackgroundTaskWithExpirationHandler:^{
if (backgroundTaskId != UIBackgroundTaskInvalid) {
[application endBackgroundTask:backgroundTaskId];
backgroundTaskId = UIBackgroundTaskInvalid;
}
}];
// TODO add support in a later version for calling completion handler directly from JS when user JS code complete
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t) (25 * NSEC_PER_SEC)), dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0), ^{
completionHandler(UIBackgroundFetchResultNewData);

//Stoping background task here, as this is longest timeout, so we are sure that it is executed
mikehardy marked this conversation as resolved.
Show resolved Hide resolved
if (backgroundTaskId != UIBackgroundTaskInvalid) {
[application endBackgroundTask:backgroundTaskId];
backgroundTaskId = UIBackgroundTaskInvalid;
}
});

// TODO investigate later - RN bridge gets invalidated at start when in background and a new bridge created - losing all events
Expand Down