Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, crashlytics): allow Crashlytics inclusion w/o Analytics #4134

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

mikehardy
Copy link
Collaborator

Description

@react-native-firebase/crashlytics was still bringing in Firebase/Analytics pod on iOS which disqualifies apps from being in the kids category on the App Store

This came from the remaining Firebase/Core pod dep in RNFBCrashlytics.podspec, which is no longer necessary - Firebase/CoreOnly is sufficient and that dependency is satisfied transitively by RNFBApp.podspec

Related issues

#4072 - initial issue
#4131 - initial PR that fixed almost all the modules

Interested parties @pabloearg and @dlockwo

Release Summary

Title of PR

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I overhauled my demonstrator script so that it could run in a '--no-idfa' mode (excluding admob and analytics) to verify all modules except those two work correctly. Then inspection of the Podfile.lock showed we were free of all the forbidden (by Apple, for kids apps) dependencies

mikehardy/rnfbdemo@4a716e9


Think react-native-firebase is great? Please consider supporting the project with any of the below:

There is no hard requirement for Crashlytics to bring in Firebase/Core,
and if you do so it also brings in Firebase/Analytics which disqualifies
iOS apps from being in the kids category.
@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/kpaiqq7ux
✅ Preview: https://react-native-firebase-git-crashlytics-no-core-dep.invertase.vercel.app

@mikehardy mikehardy requested a review from Salakar August 25, 2020 17:20
@mikehardy mikehardy merged commit e023b71 into master Aug 25, 2020
@mikehardy mikehardy deleted the crashlytics-no-core-dep branch August 25, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants