-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(messaging,ios): add notification extension service to support im… #4085
Merged
mikehardy
merged 3 commits into
invertase:master
from
davidepalazzo:feature/ios-image-notification
Aug 15, 2020
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
packages/messaging/ios/RNFBMessaging/RNFBMessaging+UNNotificationServiceExtension.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /** | ||
| * Copyright (c) 2016-present Invertase Limited & Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this library except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| #import <UserNotifications/UserNotifications.h> | ||
|
|
||
| @interface RNFBMessagingNotificationServiceExtension : UNNotificationServiceExtension | ||
|
|
||
| @end /* RNFBMessaging_UNNotificationServiceExtension_h */ |
49 changes: 49 additions & 0 deletions
49
packages/messaging/ios/RNFBMessaging/RNFBMessaging+UNNotificationServiceExtension.m
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /** | ||
| * Copyright (c) 2016-present Invertase Limited & Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this library except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| #import "RNFBMessaging+UNNotificationServiceExtension.h" | ||
| #import "FirebaseMessaging.h" | ||
|
|
||
| API_AVAILABLE(ios(10.0)) | ||
| @interface RNFBMessagingNotificationServiceExtension () | ||
|
|
||
| @property (nonatomic, strong) void (^contentHandler)(UNNotificationContent *contentToDeliver); | ||
| @property (nonatomic, strong) UNMutableNotificationContent *bestAttemptContent; | ||
|
|
||
| @end | ||
|
|
||
| @implementation RNFBMessagingNotificationServiceExtension | ||
|
|
||
| - (void)didReceiveNotificationRequest:(UNNotificationRequest *)request withContentHandler:(void (^)(UNNotificationContent * _Nonnull))contentHandler API_AVAILABLE(ios(10.0)) API_AVAILABLE(ios(10.0)){ | ||
| self.contentHandler = contentHandler; | ||
| self.bestAttemptContent = [request.content mutableCopy]; | ||
|
|
||
| if (@available(iOS 10.0, *)) { | ||
| [[FIRMessaging extensionHelper] populateNotificationContent:self.bestAttemptContent withContentHandler:contentHandler]; | ||
| } else { | ||
| // Fallback on earlier versions | ||
| self.contentHandler(self.bestAttemptContent); | ||
| } | ||
| } | ||
|
|
||
| - (void)serviceExtensionTimeWillExpire { | ||
| // Called just before the extension will be terminated by the system. | ||
| // Use this as an opportunity to deliver your "best attempt" at modified content, otherwise the original push payload will be used. | ||
| self.contentHandler(self.bestAttemptContent); | ||
| } | ||
|
|
||
| @end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - I had thought RNFB moved to iOS10 as a minimum but it still supports 9 right now: https://github.com/invertase/react-native-firebase/blob/master/packages/messaging/RNFBMessaging.podspec#L28 - it's Notifee and React-Native itself (with version 0.63) that have moved to 10 already