Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove flow types #3954

Merged
merged 5 commits into from
Jul 30, 2020
Merged

refactor!: remove flow types #3954

merged 5 commits into from
Jul 30, 2020

Conversation

russellwheatley
Copy link
Member

Description

Removed Flow types.

Related issues

No issue created for this PR.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@russellwheatley russellwheatley changed the title @russell/remove flow chore(*): removed flow types Jul 16, 2020
@russellwheatley russellwheatley marked this pull request as ready for review July 16, 2020 10:55
@Salakar
Copy link
Member

Salakar commented Jul 16, 2020

Another one here: https://github.com/invertase/react-native-firebase/blob/master/packages/app/package.json#L57

@Salakar Salakar changed the title chore(*): removed flow types refactor!: remove flow types Jul 16, 2020
@russellwheatley russellwheatley merged commit bf0611f into master Jul 30, 2020
@russellwheatley russellwheatley deleted the @russell/remove-flow branch July 30, 2020 09:12
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
@russellwheatley
refactor!: remove flow types (invertase#3954)
c2197d4 
* chore(*): removed flow types

* chore(app): rm app-types package
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
@russellwheatley
refactor!: remove flow types (invertase#3954)
eaa08ef 
* chore(*): removed flow types

* chore(app): rm app-types package
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
@russellwheatley
refactor!: remove flow types (invertase#3954)
0433bbe 
* chore(*): removed flow types

* chore(app): rm app-types package
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Sep 15, 2021
@russellwheatley
refactor!: remove flow types (invertase#3954)
87e714f 
* chore(*): removed flow types

* chore(app): rm app-types package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salakar Salakar Salakar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russellwheatley @Salakar