Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onTokenChange method causing app to crash #3552

Merged
merged 7 commits into from
May 5, 2020
Merged

fix: onTokenChange method causing app to crash #3552

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4fcdbfa
fix: onTokenChange method causing app to crash
focux Apr 27, 2020
5851365
Merge branch 'master' into fix-on-token-change-crash
Salakar Apr 27, 2020
ccde7d1
Merge branch 'master' into fix-on-token-change-crash
focux Apr 28, 2020
1617831
fix: use token instead of token with string ancestor
focux Apr 28, 2020
0d0b3df
Merge branch 'fix-on-token-change-crash' of github.com:focux/react-na…
focux Apr 28, 2020
4f8e12d
Merge branch 'master' into fix-on-token-change-crash
focux May 1, 2020
6b11e96
Merge branch 'master' into fix-on-token-change-crash
focux May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions packages/messaging/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,20 +198,8 @@ class FirebaseMessagingModule extends FirebaseModule {
}

const subscription = this.emitter.addListener('messaging_token_refresh', event => {
// TODO remove after v7.0.0, see: https://github.com/invertase/react-native-firebase/issues/2889
const { token } = event;
const tokenStringWithTokenAccessor = String(token);
Object.defineProperty(tokenStringWithTokenAccessor, 'token', {
enumerable: false,
get() {
// eslint-disable-next-line no-console
console.warn(
'firebase.messaging().onTokenRefresh(event => event.token) is deprecated, use onTokenRefresh(token => token) or call getToken() instead',
);
return token;
},
});
listener(tokenStringWithTokenAccessor);
listener(token);
});
return () => subscription.remove();
}
Expand Down