Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version to .flowconfig #30

Merged
merged 2 commits into from
Apr 4, 2017
Merged

Conversation

benadamstyles
Copy link
Contributor

The consequence of this is that flow will not run in this project unless you have [email protected] installed. One solution to this is adding flow-bin to this package's devDependencies.

The consequence of this is that **flow will not run in this project** unless you have `[email protected]` installed. One solution to this is adding `flow-bin` to this package's devDependencies.
@benadamstyles
Copy link
Contributor Author

I'm not 100% sure what will happen if someone's react native project is using a different version of flow. Maybe we need to think further about the consequences of this PR. One alternative would be to install [email protected] and not merge this PR... then contributors to this package would just use the local flow-bin to dev against. What do you think?

@chrisbianca
Copy link
Contributor

I'd be inclined to follow what has been done in the main RN project and add flow-bin to RN-Firebase's devDependencies. At least you ensuring that when developing with the library, everybody is using the same version of Flow and working to a consistent standard?

@benadamstyles
Copy link
Contributor Author

Yep, sounds good, although the main RN project also has the [version] entry in .flowconfig. I've tried to look for advice for package authors on this subject but no luck. I think I'll close this PR and submit a new one with the flow-bin dependency (matching the [version] specified in the latest stable RN release. Sound ok?

@chrisbianca
Copy link
Contributor

I don't think there's any harm to having it specified in .flowconfig as long as they match.. I'd just modify this PR and add the flow-bin dev dependency as well

@benadamstyles
Copy link
Contributor Author

Ok 👍

@chrisbianca chrisbianca merged commit 34746c2 into invertase:master Apr 4, 2017
@benadamstyles benadamstyles deleted the patch-1 branch April 4, 2017 12:41
@Salakar
Copy link
Contributor

Salakar commented Apr 4, 2017

@Leeds-eBooks thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants