-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios, storage): handle nil file extension from ios14 M1 emulators #4676
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/lhk34oyur |
Thanks @Maxoos - it looks like the CLA still isn't signed? If you can sign that I can work this through the QA process and merge it |
Hi @Maxoos ! Unfortunately without the CLA signed (you can follow the instructions above or click the 'details' link on the license/cla check) we cannot merge this and I will have to close it |
Sorry @mikehardy was a bit full on before the holidays. Should be all sorted now! |
e6ca28d
to
2b4e65f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4676 +/- ##
=======================================
Coverage 89.09% 89.09%
=======================================
Files 109 109
Lines 3712 3712
Branches 347 347
=======================================
Hits 3307 3307
Misses 363 363
Partials 42 42 |
2b4e65f
to
0e7c222
Compare
Description
This fix resolves a crash that occurs when pathExtension returns NULL, failing to detect file extension. This was detected as a result of a simulator bug with Apple Silicon Macs where pathExtension returns NULL only iOS14 (works as expected on iOS13).
This bug would probably surface on any device if file extension could not be detected when calling mimeTypeForPath, this could be used to verify the fix on intel Macs.
Related issues
Fixes #4661
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Verified mimeTypeForPath function on Apple Silicon with iOS14 sim to return @"application/octet-stream". Verified CFRelease is being called on iOS13 sim.
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter