[Crash] putFile will crash when extension in unknown

[Maxoos]

I'm running xcode12 on Apple Silicon and it seems that pathExtension which used to return the extensions of the file in path is returning nil on iOS14 simulators (for gif files - does not happen on iOS13). This is probably a simulator issue, however, this code does not check if UTI is null and therefor crashes when trying to release:

CFRelease(UTI);

react-native-firebase/packages/storage/ios/RNFBStorage/RNFBStorageCommon.m

Lines 62 to 66 in b535757

	CFStringRef UTI = UTTypeCreatePreferredIdentifierForTag(kUTTagClassFilenameExtension,
	(__bridge CFStringRef) [localFilePath pathExtension],
	NULL);
	CFStringRef mimeType = UTTypeCopyPreferredTagWithClass(UTI, kUTTagClassMIMEType);
	CFRelease(UTI);

It should be something like:

if (UTI) { CFRelease(UTI); }

Return value can be null according to the documentation:

Return Value
A new CFStringRef containing a uniform type identifier, or NULL if inTagClass is not a known tag class

[mikehardy]

Oh my! Good catch @Maxoos - if you could work up a PR for this (for small patches I start by just modifying the file directly in node_modules then doing a patch-package for it) so you know it is tested and working and fixes your failure case, I'd happily merge it

[fongabc]

I have the same issue on Apple Silicon

[fongabc]

I have the same issue on Apple Silicon

I found out that the issue occurs on simulator but not in the physical device.

[mikehardy]

I would still love to fix this for the simulator if someone worked up a PR for it and submitted it here. I don't have Apple Silicon so I cannot test it to verify if it's working, I will need someone from the community to propose it and verify it works for them

[Maxoos]

@mikehardy I've created a PR, I think you might be able to test this on an Intel based Mac by trying a file with no extension. Thanks!