Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, messaging): remove UNNotificationServiceExtension in favour of local target extension #4226

Merged

Conversation

davidepalazzo
Copy link
Contributor

Description

As covered in #4218 I'm removing the code I added with #4085 as it seems it isn't stable enough.

The new additional documentation added with #4225 will provide a better way to enable images in messaging. More details on the reason for this change can be seen on the Apple's documentation about Notification Extension.

Related issues

#4218

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Sep 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/b1rjnfp8w
✅ Preview: https://react-native-f-git-fork-davidepalazzo-fix-ios-image-noti-8745e8.invertase.vercel.app

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on the docs PR but this looks good as a companion to it

@mikehardy mikehardy merged commit 1be2a39 into invertase:master Sep 10, 2020
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants