-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[📚] Add description about adding extension to iOS App to receive notification with image #4218
Comments
Hi there! This feature is generally available for anyone I think? #4085 And it has been documented? #4089 https://rnfirebase.io/messaging/server-integration#ios Is there some other place this could be to make it more obvious? |
@mikehardy I know Firebase has a document about creating a notification with image, but we should appeal to developer that we have an easier way to implement it. |
Did you follow the links I sent? |
@mikehardy @davidepalazzo |
I'm facing the same problem. Doesn't seem like the extension works out of the box without having to do additional steps, but not sure. @davidepalazzo I'm creating my own extension then trying to inherit the RNFBMessaging one but no luck. |
Hi @Pittan. Yes, that was the intent of the PR. Although, it looks like it stopped working. I tested it with a fresh install – the payload comes through fine, the notification is displayed but the image isn't showing. Not too sure what changed since I pushed the code. Hey @helenaford, I found that to make it work with you need to target
This is a solid solution and should work reliably. @mikehardy, I'm happy to extend on the above steps and add it to the doc. I'll remove the previous code I added in favour of the native extension as I feel this is a better and more stable approach. Thoughts? |
@davidepalazzo I trust your judgement and will happily work with you to ingest the change here, thanks for the offer |
No worries @mikehardy, I'm more than happy to work on this change and have a PR within a few days. In terms of structure, I'd probably move out the instructions from under |
That sounds good |
Hey @mikehardy, I just pushed 2 PRs:
Cheers. |
Please support for ipad! iphone worked but ipad not working. |
@vuongductuanktmt try changing the version of the Notification Service Extension to a lower value: It should match whatever version you're using in your main app target. iOS 10 is the minimum version required to make this work. |
@mikehardy Thank you for your cooperation! |
Documentation Feedback
https://rnfirebase.io/messaging/server-integration#ios
Hello! I'm working on a new App for iOS built with React Native and react-native-firebase!
@react-native-firebase/messaging
is awesome to implement notification feature quickly!But I thought adding "You must create an App-extension to receive notification with image" to its document will be nice for beginners.
I had a few background for iOS App developing, so it won't be a huge problem.
But maybe for people who are not familiar with iOS App developing, it would be a great assist!
React Native Firebase
andInvertase
on Twitter for updates on the library.The text was updated successfully, but these errors were encountered: