Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage docs with iOS image information #4089

Closed
mikehardy opened this issue Aug 14, 2020 · 2 comments · Fixed by #4094
Closed

Update usage docs with iOS image information #4089

mikehardy opened this issue Aug 14, 2020 · 2 comments · Fixed by #4094

Comments

@mikehardy
Copy link
Collaborator

Code LGTM. Re the docs, could maybe briefly mention it on this page: https://rnfirebase.io/messaging/server-integration#send-messages-to-topics - happy for this to be in a follow up PR if you want to ship this for now.

Originally posted by @Salakar in #4085 (comment)
@mikehardy
Copy link
Collaborator Author

@davidepalazzo - I peeled off the docs suggestion so the functionality isn't blocked

@davidepalazzo davidepalazzo mentioned this issue Aug 15, 2020
Merged
8 tasks
@davidepalazzo
Copy link
Contributor

Great, thanks for that @mikehardy. I just pushed the changes to the doc.

@mikehardy mikehardy mentioned this issue Sep 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(messaging): sending image in messages davidepalazzo/react-native-firebase
2 participants
@mikehardy @davidepalazzo