Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect definition of firebase.notifications.Android.Importance.None #1213

Closed
aMarCruz opened this issue Jun 14, 2018 · 0 comments
Closed

Incorrect definition of firebase.notifications.Android.Importance.None #1213

aMarCruz opened this issue Jun 14, 2018 · 0 comments

Comments

@aMarCruz
Copy link
Contributor

Issue

The definition of Importance.None in lib/modules/notifications/types.js is 3, however in the Google docs it is defined as 0.

Environment

Platform: Android
Development Operating System: Linux Mint 18.3
Build Tools: Android Studio 3.2, Android SDK 27
React Native version: 54.x
RNFirebase Version: 4.2
Firebase Module: notifications

@Salakar I think the Importan.None value in types.js is incorrect.
chrisbianca added a commit that referenced this issue Jun 17, 2018
@chrisbianca
Merge pull request #1220 from aMarCruz/importance-none
ab35573 
Closes #1213 : Incorrect definition of Android.Importance.None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aMarCruz