add expo dep needed for plugin, update snapshots, auto-fix lint error

invertase · Mar 21, 2024 · e5874c0 · e5874c0
1 parent 3aa4c25
commit e5874c0
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 8 deletions.
diff --git a/packages/app-check/package.json b/packages/app-check/package.json
@@ -23,7 +23,16 @@
     "appCheck"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "19.0.1"
+    "@react-native-firebase/app": "19.0.1",
+    "expo": ">=47.0.0"
+  },
+  "devDependencies": {
+    "expo": "^49.0.21"
+  },
+  "peerDependenciesMeta": {
+    "expo": {
+      "optional": true
+    }
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/app-check/plugin/__tests__/__snapshots__/iosPlugin.test.ts.snap b/packages/app-check/plugin/__tests__/__snapshots__/iosPlugin.test.ts.snap
@@ -41,7 +41,7 @@ static void InitializeFlipper(UIApplication *application) {
   InitializeFlipper(application);
 #endif
   
-// @generated begin @react-native-firebase/app-check-didFinishLaunchingWithOptions - expo prebuild (DO NOT MODIFY) sync-5b7813c3af090f886568429140e982730142dbe7
+// @generated begin @react-native-firebase/app-check-didFinishLaunchingWithOptions - expo prebuild (DO NOT MODIFY) sync-39c06fe0cc03ffe4bc9cc005b839c559e7ba13d2
 [RNFBAppCheckModule sharedInstance];
 // @generated end @react-native-firebase/app-check-didFinishLaunchingWithOptions
   RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
@@ -134,7 +134,7 @@ static void InitializeFlipper(UIApplication *application) {
   InitializeFlipper(application);
 #endif
   
-// @generated begin @react-native-firebase/app-check-didFinishLaunchingWithOptions - expo prebuild (DO NOT MODIFY) sync-5b7813c3af090f886568429140e982730142dbe7
+// @generated begin @react-native-firebase/app-check-didFinishLaunchingWithOptions - expo prebuild (DO NOT MODIFY) sync-39c06fe0cc03ffe4bc9cc005b839c559e7ba13d2
 [RNFBAppCheckModule sharedInstance];
 // @generated end @react-native-firebase/app-check-didFinishLaunchingWithOptions
   RCTBridge *bridge = [self.reactDelegate createBridgeWithDelegate:self launchOptions:launchOptions];
@@ -201,7 +201,7 @@ exports[`Config Plugin iOS Tests tests changes made to AppDelegate.m with fallba
 
 - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
 {
-// @generated begin @react-native-firebase/app-didFinishLaunchingWithOptions-fallback - expo prebuild (DO NOT MODIFY) sync-5b7813c3af090f886568429140e982730142dbe7
+// @generated begin @react-native-firebase/app-didFinishLaunchingWithOptions-fallback - expo prebuild (DO NOT MODIFY) sync-39c06fe0cc03ffe4bc9cc005b839c559e7ba13d2
 [RNFBAppCheckModule sharedInstance];
 // @generated end @react-native-firebase/app-didFinishLaunchingWithOptions-fallback
 
@@ -287,7 +287,7 @@ static void InitializeFlipper(UIApplication *application) {
   InitializeFlipper(application);
 #endif
   
-// @generated begin @react-native-firebase/app-check-didFinishLaunchingWithOptions - expo prebuild (DO NOT MODIFY) sync-5b7813c3af090f886568429140e982730142dbe7
+// @generated begin @react-native-firebase/app-check-didFinishLaunchingWithOptions - expo prebuild (DO NOT MODIFY) sync-39c06fe0cc03ffe4bc9cc005b839c559e7ba13d2
 [RNFBAppCheckModule sharedInstance];
 // @generated end @react-native-firebase/app-check-didFinishLaunchingWithOptions
   self.moduleRegistryAdapter = [[UMModuleRegistryAdapter alloc] initWithModuleRegistryProvider:[[UMModuleRegistryProvider alloc] init]];
@@ -386,7 +386,7 @@ exports[`Config Plugin iOS Tests works with AppDelegate.mm (RN 0.68+) 1`] = `
 {
   RCTAppSetupPrepareApp(application);
 
-// @generated begin @react-native-firebase/app-check-didFinishLaunchingWithOptions - expo prebuild (DO NOT MODIFY) sync-5b7813c3af090f886568429140e982730142dbe7
+// @generated begin @react-native-firebase/app-check-didFinishLaunchingWithOptions - expo prebuild (DO NOT MODIFY) sync-39c06fe0cc03ffe4bc9cc005b839c559e7ba13d2
 [RNFBAppCheckModule sharedInstance];
 // @generated end @react-native-firebase/app-check-didFinishLaunchingWithOptions
   RCTBridge *bridge = [self.reactDelegate createBridgeWithDelegate:self launchOptions:launchOptions];

diff --git a/packages/app-check/plugin/__tests__/iosPlugin.test.ts b/packages/app-check/plugin/__tests__/iosPlugin.test.ts
@@ -88,8 +88,7 @@ describe('Config Plugin iOS Tests', function () {
   });
 
   it('does not add the firebase import multiple times', async function () {
-    const singleImport =
-      '#import "AppDelegate.h"\n#import <RNFBAppCheckModule.h>';
+    const singleImport = '#import "AppDelegate.h"\n#import <RNFBAppCheckModule.h>';
     const doubleImport = singleImport + '\n#import <RNFBAppCheckModule.h>';
 
     const appDelegate = await fs.readFile(path.join(__dirname, './fixtures/AppDelegate_sdk45.mm'), {

diff --git a/yarn.lock b/yarn.lock
@@ -4119,8 +4119,14 @@ __metadata:
 "@react-native-firebase/app-check@npm:19.0.1, @react-native-firebase/app-check@workspace:packages/app-check":
   version: 0.0.0-use.local
   resolution: "@react-native-firebase/app-check@workspace:packages/app-check"
+  dependencies:
+    expo: "npm:^49.0.21"
   peerDependencies:
     "@react-native-firebase/app": 19.0.1
+    expo: ">=47.0.0"
+  peerDependenciesMeta:
+    expo:
+      optional: true
   languageName: unknown
   linkType: soft