Skip to content

Commit

Permalink
tests(auth, e2e): re-enable tests, use auth emulator
Browse files Browse the repository at this point in the history 
Found at least 2 unexpected real issues in RNFB along the way
Found at least 3 Firebase internal errors marked with FIXME that need upstream logging

Auth emulator is great, no API limits and now we can cover phone auth and email verify/signin flow in testing
  • Loading branch information
@mikehardy
mikehardy committed Nov 16, 2020
1 parent 8ff920c commit 4c68841
Show file tree
Hide file tree
Showing 10 changed files with 545 additions and 188 deletions.
11 changes: 11 additions & 0 deletions packages/app/e2e/helpers.js
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
exports.getE2eTestProject = function getE2eTestProject() {
return 'react-native-firebase-testing';
};

exports.getE2eEmulatorHost = function getE2eEmulatorHost() {
// Note that in most package implementations involving the emulator, we re-write
// localhost and 127.0.0.1 on Android to 10.0.2.2 (the Android emulator host interface)
// But this specific code is executing in the host context even during E2E test.
// So no re-write is necessary here.
return 'localhost';
};
172 changes: 128 additions & 44 deletions packages/auth/e2e/auth.e2e.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,31 @@
*
*/

const TEST_EMAIL = '[email protected]';
const TEST_PASS = 'test1234';

const DISABLED_EMAIL = '[email protected]';
const DISABLED_PASS = 'test1234';

const { clearAllUsers, disableUser, getLastOob, resetPassword } = require('./helpers');

describe('auth()', () => {
before(async () => {
await clearAllUsers();
await firebase.auth().createUserWithEmailAndPassword(TEST_EMAIL, TEST_PASS);
const disabledUserCredential = await firebase
.auth()
.createUserWithEmailAndPassword(DISABLED_EMAIL, DISABLED_PASS);
await disableUser(disabledUserCredential.user.uid);
});

beforeEach(async () => {
if (firebase.auth().currentUser) {
await firebase.auth().signOut();
await Utils.sleep(50);
}
});

describe('namespace', () => {
it('accessible from firebase.app()', () => {
const app = firebase.app();
Expand All @@ -39,6 +63,7 @@ describe('auth()', () => {
});

describe('applyActionCode()', () => {
// Needs a different setup to work against the auth emulator
xit('works as expected', async () => {
await firebase
.auth()
Expand Down Expand Up @@ -106,18 +131,8 @@ describe('auth()', () => {
});
});

describe('verifyPasswordResetCode()', () => {
it('errors on invalid code', async () => {
try {
await firebase.auth().verifyPasswordResetCode('fooby shooby dooby');
} catch (e) {
e.message.should.containEql('code is invalid');
}
});
});

describe('confirmPasswordReset()', () => {
it('errors on invalid code', async () => {
it('errors on invalid code via API', async () => {
try {
await firebase.auth().confirmPasswordReset('fooby shooby dooby', 'passwordthing');
} catch (e) {
Expand All @@ -127,16 +142,14 @@ describe('auth()', () => {
});

describe('signInWithCustomToken()', () => {
it('signs in with a admin sdk created custom auth token', async () => {
const email = '[email protected]';
const pass = 'test1234';

// Needs a different setup when running against the emulator
xit('signs in with a admin sdk created custom auth token', async () => {
const successCb = currentUserCredential => {
const currentUser = currentUserCredential.user;
currentUser.should.be.an.Object();
currentUser.uid.should.be.a.String();
currentUser.toJSON().should.be.an.Object();
currentUser.toJSON().email.should.eql(email);
currentUser.toJSON().email.should.eql(TEST_EMAIL);
currentUser.isAnonymous.should.equal(false);
currentUser.providerId.should.equal('firebase');
currentUser.should.equal(firebase.auth().currentUser);
Expand All @@ -150,7 +163,7 @@ describe('auth()', () => {

const user = await firebase
.auth()
.signInWithEmailAndPassword(email, pass)
.signInWithEmailAndPassword(TEST_EMAIL, TEST_PASS)
.then(successCb);

const IdToken = await firebase.auth().currentUser.getIdToken();
Expand All @@ -162,7 +175,7 @@ describe('auth()', () => {

await firebase.auth().signInWithCustomToken(token);

firebase.auth().currentUser.email.should.equal('[email protected]');
firebase.auth().currentUser.email.should.equal(TEST_EMAIL);
});
});

Expand Down Expand Up @@ -540,15 +553,12 @@ describe('auth()', () => {

describe('signInWithEmailAndPassword()', () => {
it('it should login with email and password', () => {
const email = '[email protected]';
const pass = 'test1234';

const successCb = currentUserCredential => {
const currentUser = currentUserCredential.user;
currentUser.should.be.an.Object();
currentUser.uid.should.be.a.String();
currentUser.toJSON().should.be.an.Object();
currentUser.toJSON().email.should.eql(email);
currentUser.toJSON().email.should.eql(TEST_EMAIL);
currentUser.isAnonymous.should.equal(false);
currentUser.providerId.should.equal('firebase');
currentUser.should.equal(firebase.auth().currentUser);
Expand All @@ -562,14 +572,11 @@ describe('auth()', () => {

return firebase
.auth()
.signInWithEmailAndPassword(email, pass)
.signInWithEmailAndPassword(TEST_EMAIL, TEST_PASS)
.then(successCb);
});

it('it should error on login if user is disabled', () => {
const email = '[email protected]';
const pass = 'test1234';

const successCb = () => Promise.reject(new Error('Did not error.'));

const failureCb = error => {
Expand All @@ -580,15 +587,12 @@ describe('auth()', () => {

return firebase
.auth()
.signInWithEmailAndPassword(email, pass)
.signInWithEmailAndPassword(DISABLED_EMAIL, DISABLED_PASS)
.then(successCb)
.catch(failureCb);
});

it('it should error on login if password incorrect', () => {
const email = '[email protected]';
const pass = 'test1234666';

const successCb = () => Promise.reject(new Error('Did not error.'));

const failureCb = error => {
Expand All @@ -601,7 +605,7 @@ describe('auth()', () => {

return firebase
.auth()
.signInWithEmailAndPassword(email, pass)
.signInWithEmailAndPassword(TEST_EMAIL, TEST_PASS + '666')
.then(successCb)
.catch(failureCb);
});
Expand Down Expand Up @@ -631,14 +635,14 @@ describe('auth()', () => {

describe('signInWithCredential()', () => {
it('it should login with email and password', () => {
const credential = firebase.auth.EmailAuthProvider.credential('[email protected]', 'test1234');
const credential = firebase.auth.EmailAuthProvider.credential(TEST_EMAIL, TEST_PASS);

const successCb = currentUserCredential => {
const currentUser = currentUserCredential.user;
currentUser.should.be.an.Object();
currentUser.uid.should.be.a.String();
currentUser.toJSON().should.be.an.Object();
currentUser.toJSON().email.should.eql('[email protected]');
currentUser.toJSON().email.should.eql(TEST_EMAIL);
currentUser.isAnonymous.should.equal(false);
currentUser.providerId.should.equal('firebase');
currentUser.should.equal(firebase.auth().currentUser);
Expand All @@ -657,10 +661,7 @@ describe('auth()', () => {
});

it('it should error on login if user is disabled', () => {
const credential = firebase.auth.EmailAuthProvider.credential(
'[email protected]',
'test1234',
);
const credential = firebase.auth.EmailAuthProvider.credential(DISABLED_EMAIL, DISABLED_PASS);

const successCb = () => Promise.reject(new Error('Did not error.'));

Expand All @@ -678,7 +679,7 @@ describe('auth()', () => {
});

it('it should error on login if password incorrect', () => {
const credential = firebase.auth.EmailAuthProvider.credential('[email protected]', 'test1234666');
const credential = firebase.auth.EmailAuthProvider.credential(TEST_EMAIL, TEST_PASS + '666');

const successCb = () => Promise.reject(new Error('Did not error.'));

Expand Down Expand Up @@ -770,9 +771,6 @@ describe('auth()', () => {
});

it('it should error on create if email in use', () => {
const email = '[email protected]';
const pass = 'test123456789';

const successCb = () => Promise.reject(new Error('Did not error.'));

const failureCb = error => {
Expand All @@ -783,7 +781,7 @@ describe('auth()', () => {

return firebase
.auth()
.createUserWithEmailAndPassword(email, pass)
.createUserWithEmailAndPassword(TEST_EMAIL, TEST_PASS)
.then(successCb)
.catch(failureCb);
});
Expand Down Expand Up @@ -824,7 +822,7 @@ describe('auth()', () => {

return firebase
.auth()
.fetchSignInMethodsForEmail('[email protected]')
.fetchSignInMethodsForEmail(TEST_EMAIL)
.then(successCb)
.catch(failureCb);
}));
Expand Down Expand Up @@ -982,11 +980,97 @@ describe('auth()', () => {

try {
await firebase.auth().sendPasswordResetEmail(email);
} catch (error) {
throw new Error('sendPasswordResetEmail() caused an error', error);
} finally {
await firebase.auth().currentUser.delete();
}
});

it('should verify with valid code', async () => {
// FIXME Fails on android against auth emulator with:
// com.google.firebase.FirebaseException: An internal error has occurred.
if (device.getPlatform() === 'ios') {
const random = Utils.randString(12, '#a');
const email = `${random}@${random}.com`;
const userCredential = await firebase.auth().createUserWithEmailAndPassword(email, random);
userCredential.user.emailVerified.should.equal(false);
firebase.auth().currentUser.email.should.equal(email);
firebase.auth().currentUser.emailVerified.should.equal(false);

try {
await firebase.auth().sendPasswordResetEmail(email);
const { oobCode } = await getLastOob(email);
await firebase.auth().verifyPasswordResetCode(oobCode);
} catch (error) {
throw new Error('sendPasswordResetEmail() caused an error', error);
} finally {
await firebase.auth().currentUser.delete();
}
}
});

it('should fail to verify with invalid code', async () => {
const random = Utils.randString(12, '#a');
const email = `${random}@${random}.com`;
const userCredential = await firebase.auth().createUserWithEmailAndPassword(email, random);
userCredential.user.emailVerified.should.equal(false);
firebase.auth().currentUser.email.should.equal(email);
firebase.auth().currentUser.emailVerified.should.equal(false);

try {
await firebase.auth().sendPasswordResetEmail(email);
const { oobCode } = await getLastOob(email);
await firebase.auth().verifyPasswordResetCode(oobCode + 'badcode');
throw new Error('Invalid code should throw an error');
} catch (error) {
error.message.should.containEql('[auth/invalid-action-code]');
} finally {
await firebase.auth().currentUser.delete();
}
});

it('should change password correctly OOB', async () => {
const random = Utils.randString(12, '#a');
const email = `${random}@${random}.com`;
const userCredential = await firebase.auth().createUserWithEmailAndPassword(email, random);
userCredential.user.emailVerified.should.equal(false);
firebase.auth().currentUser.email.should.equal(email);
firebase.auth().currentUser.emailVerified.should.equal(false);

try {
await firebase.auth().sendPasswordResetEmail(email);
const { oobCode } = await getLastOob(email);
await resetPassword(oobCode, 'testNewPassword');
await firebase.auth().signOut();
await Utils.sleep(50);
await firebase.auth().signInWithEmailAndPassword(email, 'testNewPassword');
} catch (error) {
// Reject
throw new Error('sendPasswordResetEmail() caused an error', error);
} finally {
await firebase.auth().currentUser.delete();
}
});

it('should change password correctly via API', async () => {
const random = Utils.randString(12, '#a');
const email = `${random}@${random}.com`;
const userCredential = await firebase.auth().createUserWithEmailAndPassword(email, random);
userCredential.user.emailVerified.should.equal(false);
firebase.auth().currentUser.email.should.equal(email);
firebase.auth().currentUser.emailVerified.should.equal(false);

try {
await firebase.auth().sendPasswordResetEmail(email);
const { oobCode } = await getLastOob(email);
await firebase.auth().confirmPasswordReset(oobCode, 'testNewPassword');
await firebase.auth().signOut();
await Utils.sleep(50);
await firebase.auth().signInWithEmailAndPassword(email, 'testNewPassword');
} catch (error) {
throw new Error('sendPasswordResetEmail() caused an error', error);
} finally {
await firebase.auth().currentUser.delete();
}
});
});
Expand Down
26 changes: 26 additions & 0 deletions packages/auth/e2e/emailLink.e2e.js
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
const { getLastOob, signInUser } = require('./helpers');

describe('auth() -> emailLink Provider', () => {
beforeEach(async () => {
if (firebase.auth().currentUser) {
Expand Down Expand Up @@ -26,6 +28,30 @@ describe('auth() -> emailLink Provider', () => {
await firebase.auth().sendSignInLinkToEmail(email, actionCodeSettings);
});

it('sign in via email works', async () => {
const random = Utils.randString(12, '#aa');
const email = `${random}@${random}.com`;
const continueUrl = 'http://localhost:1337/authLinkFoo?bar=' + random;
const actionCodeSettings = {
url: continueUrl,
handleCodeInApp: true,
iOS: {
bundleId: 'com.testing',
},
android: {
packageName: 'com.testing',
installApp: true,
minimumVersion: '12',
},
};
await firebase.auth().sendSignInLinkToEmail(email, actionCodeSettings);
const oobInfo = await getLastOob(email);
oobInfo.oobLink.should.containEql(encodeURIComponent(continueUrl));
const signInResponse = await signInUser(oobInfo.oobLink);
signInResponse.should.containEql(continueUrl);
signInResponse.should.containEql(oobInfo.oobCode);
});

xit('should send email with defaults', async () => {
const random = Utils.randString(12, '#aA');
const email = `${random}@${random}.com`;
Expand Down
Loading

1 comment on commit 4c68841

@vercel
Copy link

@vercel vercel bot commented on 4c68841 Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

Please sign in to comment.