Add registerForRemoteNotifications method

invertase · Oct 23, 2018 · 096e50e · 096e50e
1 parent 137fe59
commit 096e50e
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/android/src/main/java/io/invertase/firebase/messaging/RNFirebaseMessaging.java b/android/src/main/java/io/invertase/firebase/messaging/RNFirebaseMessaging.java
@@ -64,6 +64,11 @@ public void requestPermission(Promise promise) {
     promise.resolve(null);
   }
 
+  @ReactMethod
+  public void registerForRemoteNotifications(Promise promise) {
+    promise.resolve(null);
+  }
+
   // Non Web SDK methods
   @ReactMethod
   public void hasPermission(Promise promise) {

diff --git a/ios/RNFirebase/messaging/RNFirebaseMessaging.m b/ios/RNFirebase/messaging/RNFirebaseMessaging.m
@@ -124,9 +124,6 @@ - (void)messaging:(nonnull FIRMessaging *)messaging
             }
         }];
     }
-    dispatch_async(dispatch_get_main_queue(), ^{
-        [RCTSharedApplication() registerForRemoteNotifications];
-    });
 }
 
 RCT_EXPORT_METHOD(requestPermission:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
@@ -159,6 +156,11 @@ - (void)messaging:(nonnull FIRMessaging *)messaging
     }
 }
 
+RCT_EXPORT_METHOD(registerForRemoteNotifications:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
+    [RCTSharedApplication() registerForRemoteNotifications];
+    resolve(nil);
+}
+
 // Non Web SDK methods
 RCT_EXPORT_METHOD(hasPermission:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
     if (floor(NSFoundationVersionNumber) <= NSFoundationVersionNumber_iOS_9_x_Max) {

diff --git a/src/index.d.ts b/src/index.d.ts
@@ -1205,6 +1205,11 @@ declare module 'react-native-firebase' {
          */
         hasPermission(): Promise<boolean>;
 
+        /**
+         * Register for iOS remote notifications
+         */
+        registerForRemoteNotifications(): Promise<void>;
+
         /**
          * Send an upstream message
          */

diff --git a/src/modules/messaging/index.js b/src/modules/messaging/index.js
@@ -137,6 +137,10 @@ export default class Messaging extends ModuleBase {
     return getNativeModule(this).hasPermission();
   }
 
+  registerForRemoteNotifications(): Promise<void> {
+    return getNativeModule(this).registerForRemoteNotifications();
+  }
+
   sendMessage(remoteMessage: RemoteMessage): Promise<void> {
     if (!(remoteMessage instanceof RemoteMessage)) {
       return Promise.reject(