Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported versions in release notes #217

Closed
wants to merge 3 commits into from

Conversation

mikehardy
Copy link
Collaborator

No description provided.

@quachsimon
Copy link

Much clearer! Can update now knowing the latest SDKs are supported.

@mikehardy
Copy link
Collaborator Author

If anyone from @invertase wants to take a look for review then, this seems to be better wording :-)

@mikehardy
Copy link
Collaborator Author

@Salakar I'd like to get this merged if possible and then use it as a base for future updates

There will be trouble as it appears they packaged MLKit breaking changes into ios pods 6.10 along with iOS13 crash fixes.

@CaptainJeff
Copy link

@mikehardy

I'm not sure I understand your point. When were the MLKit breaking changes introduced? In 6.10? And your PR is updating the documentation to use version 6.8.1 instead of 6.2?

Or am I misreading the versioning?

@mikehardy
Copy link
Collaborator Author

@CaptainJeff my note was fairly cryptic

I push these updates out periodically and they are always outdated a week after I attempt, so I may be recommending 6.8.1 in this time capsule of a PR but now for v5 I would recommend 6.10

However, v5 doesn't use MLKit which is important. v6 uses MLKit and if you use the pod version 6.10 of firebase ios sdk now you will get MLKit breaking changes which may not be what you want. So any doc updates for v6 should take that in to consideration as RNFBv6 MLKit API coverage may break as you cross from 6.9 to 6.10

This will all likely be even more out of date next week

@CaptainJeff
Copy link

@mikehardy

Understood! Thanks for your explanation.

If we don't use MLKit these breaking changes won't be an issue, correct? And 6.10 would be the preferred version

@mikehardy
Copy link
Collaborator Author

@CaptainJeff if you use v5, you can and should use most current. I use v5 and I am on 6.10. No problems. If you use v6 I can't assert anything about compatibility past 6.9.x. You'd have to try it. But if it were me and I was on v6 and it compiles and and I was not using MLKit functionality, I'd go with it.

@CaptainJeff
Copy link

@mikehardy great. Thanks for your help. I'll report back if there are any issues with 6.10

@mikehardy mikehardy closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants