Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase character limits on all link fields to 2000 #9131

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

simonkuehling
Copy link
Contributor

fixes #9106

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 28aaf5a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67c59b3c82166b0008843ce1

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (8cee2e3) to head (28aaf5a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9131      +/-   ##
==========================================
+ Coverage   86.07%   86.10%   +0.03%     
==========================================
  Files        1181     1195      +14     
  Lines       52169    52241      +72     
  Branches     2187     2187              
==========================================
+ Hits        44906    44984      +78     
+ Misses       6705     6702       -3     
+ Partials      558      555       -3     
Flag Coverage Δ
backend 88.08% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

@simonkuehling nice solution here :) I tried and failed to fix this limitation ages ago, glad that you have now worked it out!

@SchrodingersGat
Copy link
Member

@simonkuehling the database migrations here are in conflict with the latest from master - you will need to:

  1. Merge in the code from origin/master
  2. Update (renumber) your migrations
  3. Ensure that the references inside the migrations are updated to match the new migration history

@simonkuehling
Copy link
Contributor Author

@SchrodingersGat I updated the branch accordingly - i think I made a rebase instead of a merge accidentally, though... should I clean this up first, or it ok like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Increase character count for external Links as Attachments (currently 200 chars only)
4 participants