Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] fix Table Context Menu Links #8623

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Dec 2, 2024

These changes make it possible to disable context menus on right-clicks per column
Closes #8553

@matmair matmair added bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface labels Dec 2, 2024
@matmair matmair added this to the 0.17.0 milestone Dec 2, 2024
@matmair matmair self-assigned this Dec 2, 2024
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit b81a2cc
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/674e23148fb7f80008766315
😎 Deploy Preview https://deploy-preview-8623--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair
Copy link
Member Author

matmair commented Dec 2, 2024

@SchrodingersGat happy with this change? Disabling has do be done on a per-column basis; I have excluded all attachment links

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (4f3e8cb) to head (b81a2cc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/tables/InvenTreeTable.tsx 20.00% 4 Missing ⚠️
...tend/src/tables/stock/StockItemTestResultTable.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8623      +/-   ##
==========================================
+ Coverage   84.60%   84.66%   +0.05%     
==========================================
  Files        1188     1189       +1     
  Lines       54273    54285      +12     
  Branches     2050     2053       +3     
==========================================
+ Hits        45917    45958      +41     
+ Misses       7846     7809      -37     
- Partials      510      518       +8     
Flag Coverage Δ
pui 69.26% <16.66%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

@matmair seems like a reasonable fix :)

@SchrodingersGat SchrodingersGat merged commit a20fd9d into inventree:master Dec 2, 2024
29 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue8553 branch December 2, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PUI] Table Context Menu with Links
2 participants