Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Order Parts Wizard #8602

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Nov 30, 2024

Implements an "order parts" wizard for PUI, reproducing (and improving upon) the existing CUI wizard.

References

TODO

  • Provide initial "quantity" to order
  • Add "merge" option (like in CUI)
  • Adjust quantity based on supplier-part pack size
  • Generate new purchase orders as required
  • Documentation
  • Playwright testing
  • Implement from "parts" table
  • Implement from "supplier part" view
  • Implement from "part detail" view
  • Implement from "sales order" view
  • Implement from "build order" view
  • Refactor "data import" wizard to use the new components and hooks

Screenshots

image

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders Platform UI Related to the React based User Interface labels Nov 30, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 30, 2024
Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 3b0273c
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/674f81d7c182ab0008f03730
😎 Deploy Preview https://deploy-preview-8602--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 34.92063% with 123 lines in your changes missing coverage. Please review.

Project coverage is 84.56%. Comparing base (1a8b030) to head (3b0273c).

Files with missing lines Patch % Lines
...ontend/src/components/wizards/OrderPartsWizard.tsx 24.71% 67 Missing ⚠️
src/frontend/src/hooks/UseWizard.tsx 44.11% 17 Missing and 2 partials ⚠️
...c/frontend/src/components/wizards/WizardDrawer.tsx 30.76% 18 Missing ⚠️
src/frontend/src/tables/build/BuildLineTable.tsx 25.00% 6 Missing ⚠️
...ntend/src/tables/sales/SalesOrderLineItemTable.tsx 33.33% 4 Missing ⚠️
src/frontend/src/tables/stock/StockItemTable.tsx 33.33% 4 Missing ⚠️
src/frontend/src/components/items/Expand.tsx 75.00% 1 Missing ⚠️
src/frontend/src/components/render/Company.tsx 0.00% 0 Missing and 1 partial ⚠️
src/frontend/src/pages/part/PartDetail.tsx 66.66% 1 Missing ⚠️
src/frontend/src/pages/stock/StockDetail.tsx 80.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8602      +/-   ##
==========================================
- Coverage   84.68%   84.56%   -0.12%     
==========================================
  Files        1190     1194       +4     
  Lines       54296    54477     +181     
  Branches     2055     2079      +24     
==========================================
+ Hits        45980    46069      +89     
- Misses       7796     7883      +87     
- Partials      520      525       +5     
Flag Coverage Δ
pui 68.98% <34.92%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolflu05
Copy link
Contributor

wolflu05 commented Dec 2, 2024

Thanks that you have implemented the order parts wizard. Just some things that I found while testing (I know that this is highly WIP):

  • when trying to load more SPs, the table column size jumps. Maybe this needs to be fixed:
  • The button to go to the next step is really hard to find/identify
  • When I try to go to the next step it shows me an error:

I actually only tried it out yet to see if the following will be available too, but because of the third error from above, I cannot test it really, so I'll just throw that in for consideration:
Will there be an option/step to specify if you want to merge a line item or create a new line item if it already exists in the PO? With PUI we can even only show that if there is really a line item already existing.

@SchrodingersGat
Copy link
Member Author

@wolflu05 thanks for the review, this is still heavily WIP - I'll tag you when it's ready for another round of review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PUI] Implement existing Part functions
2 participants