Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hasOwn #8600

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Fix for hasOwn #8600

merged 1 commit into from
Nov 30, 2024

Conversation

SchrodingersGat
Copy link
Member

- Also add null check on function call
- Closes inventree#8595
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface labels Nov 30, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 30, 2024
Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit d33e2db
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/674ae39298f6e80008a0d3b9
😎 Deploy Preview https://deploy-preview-8600--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (3149ae7) to head (d33e2db).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/functions/auth.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8600      +/-   ##
==========================================
- Coverage   84.66%   84.64%   -0.03%     
==========================================
  Files        1189     1189              
  Lines       54279    54280       +1     
  Branches     2051     2052       +1     
==========================================
- Hits        45957    45945      -12     
- Misses       7813     7823      +10     
- Partials      509      512       +3     
Flag Coverage Δ
pui 69.17% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 7a3ceb9 into inventree:master Nov 30, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the mfa-fix branch November 30, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PUI] Login silently fails with MFA enabled
1 participant