Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow settings value to be nullified #8596

Merged

Conversation

SchrodingersGat
Copy link
Member

  • Settings values should be able to be "nulled" via UI and API
  • Allow "null" values on the field (to prevent API errors)
  • Convert any null values to empty string

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature api Relates to the API labels Nov 30, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 30, 2024
Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 8196d33
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/674a8d910f36e80008c517ad

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (20d862e) to head (8196d33).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/common/serializers.py 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8596      +/-   ##
==========================================
- Coverage   84.60%   84.59%   -0.02%     
==========================================
  Files        1189     1189              
  Lines       54264    54279      +15     
  Branches     2050     2051       +1     
==========================================
+ Hits        45910    45915       +5     
- Misses       7846     7857      +11     
+ Partials      508      507       -1     
Flag Coverage Δ
backend 86.05% <77.77%> (-0.01%) ⬇️
pui 68.87% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 3149ae7 into inventree:master Nov 30, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the plugin-model-setting branch November 30, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant