Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Hide "location" column in certain conditions #8587

Merged

Conversation

SchrodingersGat
Copy link
Member

For "consumed" stock, it does not have a "location" so the column is pointless.

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature stock Related to Stock models Platform UI Related to the React based User Interface labels Nov 28, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 28, 2024
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 13b14a7
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6748fa14bd4b2200080e11e1
😎 Deploy Preview https://deploy-preview-8587--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (7478a28) to head (13b14a7).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/tables/stock/StockItemTable.tsx 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8587      +/-   ##
==========================================
- Coverage   84.68%   84.60%   -0.08%     
==========================================
  Files        1183     1182       -1     
  Lines       54100    54097       -3     
  Branches     2044     2048       +4     
==========================================
- Hits        45813    45770      -43     
- Misses       7765     7818      +53     
+ Partials      522      509      -13     
Flag Coverage Δ
pui 69.11% <66.66%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 390828d into inventree:master Nov 28, 2024
29 checks passed
@SchrodingersGat SchrodingersGat deleted the stock-table-hide-location branch November 28, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface stock Related to Stock models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant