Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

after_save_stock_item #8546

Merged
merged 2 commits into from
Nov 25, 2024
Merged

after_save_stock_item #8546

merged 2 commits into from
Nov 25, 2024

Conversation

skydiablo
Copy link
Contributor

@skydiablo skydiablo commented Nov 25, 2024 •
edited by SchrodingersGat
Loading

This pull request addresses the issue discussed in #8452

@skydiablo
after_save_stock_item
6c866aa 
This pull request addresses the issue discussed in inventree#8452
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit e20aa44
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/674454c13787230009fbf632
😎 Deploy Preview https://deploy-preview-8546--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed stock Related to Stock models labels Nov 25, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 25, 2024
@SchrodingersGat SchrodingersGat added backport Apply this label to a PR to enable auto-backport action backport-to-0.16.x labels Nov 25, 2024
@skydiablo
Copy link
Contributor Author

skydiablo commented Nov 25, 2024 •
edited
Loading

so pyhton isnt my tech-stack and django also isnt! maybe someone can add a test-case that will check that this event handler isnt aware of the created flag? mentioned here.
thx!

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (809a978) to head (e20aa44).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8546      +/-   ##
==========================================
- Coverage   84.56%   84.47%   -0.10%     
==========================================
  Files        1178     1178              
  Lines       53690    53649      -41     
  Branches     2028     2024       -4     
==========================================
- Hits        45405    45318      -87     
- Misses       7761     7830      +69     
+ Partials      524      501      -23
Flag Coverage Δ
backend 85.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@SchrodingersGat
Copy link
Member

@skydiablo thanks for chasing this one down. I'll add in a unit test for this, and tag you in it so you can get an idea for next time ;)

@SchrodingersGat SchrodingersGat merged commit ee9980e into inventree:master Nov 25, 2024
26 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
@skydiablo
after_save_stock_item (#8546)
6c547a7 
This pull request addresses the issue discussed in #8452

(cherry picked from commit ee9980e)
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.16.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat pushed a commit that referenced this pull request Nov 25, 2024
@github-actions @skydiablo
after_save_stock_item (#8546) (#8548)
a4894d9 
This pull request addresses the issue discussed in #8452

(cherry picked from commit ee9980e)

Co-authored-by: Volker <[email protected]>
@skydiablo skydiablo deleted the patch-1 branch November 25, 2024 11:04
SchrodingersGat added a commit to SchrodingersGat/InvenTree that referenced this pull request Nov 25, 2024
@SchrodingersGat
Add unit test
1f465ba 
- Unit test to ensure event is fired when stock item is created OR updated
- Ref: inventree#8546
- Ref: inventree#8452
@SchrodingersGat SchrodingersGat mentioned this pull request Nov 25, 2024
Merged
SchrodingersGat added a commit that referenced this pull request Nov 25, 2024
@SchrodingersGat
Add unit test (#8550)
d26a683 
- Unit test to ensure event is fired when stock item is created OR updated
- Ref: #8546
- Ref: #8452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchrodingersGat SchrodingersGat Awaiting requested review from SchrodingersGat SchrodingersGat is a code owner

Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.16.x bug Identifies a bug which needs to be addressed stock Related to Stock models
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

Email Notification When Stock Level Drops Below Minimum?
2 participants
@skydiablo @SchrodingersGat