-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relation update #8524
Relation update #8524
Conversation
SchrodingersGat
commented
Nov 19, 2024
- Ref: Related parts - purpose unclear #8416
- Adds "note" field to PartRelated model
- Implement new table column in PUI
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8524 +/- ##
==========================================
+ Coverage 84.52% 84.63% +0.10%
==========================================
Files 1176 1178 +2
Lines 53555 53580 +25
Branches 2023 2025 +2
==========================================
+ Hits 45265 45345 +80
+ Misses 7785 7709 -76
- Partials 505 526 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
We might could also overengineer this by adding a second table like relation types which can be selected. That way we can keep this field much clear/filter/… by common relations types. E.g. show all additional equipment relations, … But that’s just a thought |
Using a state would probably be user-friendly as custom states would make it easy to extend the selection without adding new interfaces that need management functionality and discovery. |
@matmair should we create an issue to track this then? Maybe you could do that with you ideas about the custom states? I'm not so familiar with the new state system. |
Do you mean the same "states" used for stock items or some other feature? |
Keeping both Note and Relation type as separate table (dictionary) is the best solution here. I have never seen an example when organizing things from the start wasn`t beneficial later. The Relation type thing colud contain: direction flag (A->B, or bi-directional), optional conversion rate. This approach would allow smooth implementation of a lot of usefull things actually. Of course, just my 2c again :) |
@turist79 happy to review PRs |
sorry, but what does it mean? |
I am happy to review functioning and tested code that you submit for inclusion implementing your complicated suggestion |