-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After 0.17.0: Remove CUI #8384
base: master
Are you sure you want to change the base?
After 0.17.0: Remove CUI #8384
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8384 +/- ##
==========================================
- Coverage 84.59% 84.56% -0.03%
==========================================
Files 1182 1178 -4
Lines 53996 53688 -308
Branches 2031 2027 -4
==========================================
- Hits 45677 45403 -274
+ Misses 7816 7779 -37
- Partials 503 506 +3 ☔ View full report in Codecov by Sentry. |
That's a lot of code removed :) |
@SchrodingersGat not even all - just the parts I think that are safe. I will open PRs that port over all the test changes to 0.17.0 already to make the diff of modified files smaller in this changeset. Things like the middleware tests |
@SchrodingersGat looking through coverage several questions have popped up:
|
For now - all the features of BomDownload have not been ported across to the new framework yet.
Happy to remove if they are only ever called from the HTML templates. I'd like that as a separate PR so we can review each removed function closely
Let's do that as a separate PR - I want to ensure that all the import/export functionality has been replicated in the new system |
Should this be one PR per model or all models in one?
I have something rough for this in the pipeline, will keep it rough till 0.17.0 is through |
This PR removes CUI and adjacent helpers that are no longer required.
Part of the preparation for 1.0 as listed in the blog.
closes #5754