Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After 0.17.0: Remove CUI #8384

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

After 0.17.0: Remove CUI #8384

wants to merge 30 commits into from

Conversation

matmair
Copy link
Member

@matmair matmair commented Oct 28, 2024

This PR removes CUI and adjacent helpers that are no longer required.

Part of the preparation for 1.0 as listed in the blog.

closes #5754

@matmair matmair added old user interface Issues with Old User interface Platform UI Related to the React based User Interface labels Oct 28, 2024
@matmair matmair added this to the 1.0.0 milestone Oct 28, 2024
@matmair matmair self-assigned this Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 45d5175
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6746bd2c05bf52000864e513
😎 Deploy Preview https://deploy-preview-8384--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (81e87a6) to head (45d5175).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8384      +/-   ##
==========================================
- Coverage   84.59%   84.56%   -0.03%     
==========================================
  Files        1182     1178       -4     
  Lines       53996    53688     -308     
  Branches     2031     2027       -4     
==========================================
- Hits        45677    45403     -274     
+ Misses       7816     7779      -37     
- Partials      503      506       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

That's a lot of code removed :)

@matmair
Copy link
Member Author

matmair commented Oct 28, 2024

@SchrodingersGat not even all - just the parts I think that are safe. I will open PRs that port over all the test changes to 0.17.0 already to make the diff of modified files smaller in this changeset. Things like the middleware tests

@matmair matmair added the full-run Always do a full QC CI run label Nov 10, 2024
@matmair
Copy link
Member Author

matmair commented Nov 10, 2024

@SchrodingersGat looking through coverage several questions have popped up:

@SchrodingersGat
Copy link
Member

do we still need BomUploadTemplate and BomDownload

For now - all the features of BomDownload have not been ported across to the new framework yet.

we have a lot of model properties that are only used in the HTML templates, not the API - should we keep or remove them?

Happy to remove if they are only ever called from the HTML templates. I'd like that as a separate PR so we can review each removed function closely

there is a bunch of django-import-export stuff still in here - should I remove that too?

Let's do that as a separate PR - I want to ensure that all the import/export functionality has been replicated in the new system

@matmair
Copy link
Member Author

matmair commented Nov 10, 2024

Happy to remove if they are only ever called from the HTML templates. I'd like that as a separate PR so we can review each removed function closely

Should this be one PR per model or all models in one?

Let's do that as a separate PR - I want to ensure that all the import/export functionality has been replicated in the new system

I have something rough for this in the pipeline, will keep it rough till 0.17.0 is through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-run Always do a full QC CI run old user interface Issues with Old User interface Platform UI Related to the React based User Interface
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

[PUI] Remove custom themes
2 participants