-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SelectionList concept #8054
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8054 +/- ##
==========================================
+ Coverage 84.56% 84.59% +0.03%
==========================================
Files 1178 1183 +5
Lines 53727 54000 +273
Branches 2027 2032 +5
==========================================
+ Hits 45432 45682 +250
- Misses 7789 7815 +26
+ Partials 506 503 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/backend/InvenTree/common/migrations/0033_alter_selectionlistentry_list.py
Outdated
Show resolved
Hide resolved
@matmair this is looking pretty good in general. A few small notes below as I review: Admin CenterI like the sub-table addition within the form: Can we add a "number of items" column to the table? There is no way to see if a given selection list has any items until you click to edit it: |
src/frontend/src/pages/Index/Settings/AdminCenter/PartParameterPanel.tsx
Outdated
Show resolved
Hide resolved
- Move parameter table to default accordion
@SchrodingersGat I have addressed all open requests |
Can you please bump the API version? I will review again :) |
@SchrodingersGat done |
@matmair this is all looking nice, thanks for the good work on this! |
This PR adds the concept of SelectionLists - a way to define reusable choices for parameters (optionally controllable by plugins).
This is helpful to load and sync a list of choices into multiple instances. The usage of SelectionLists could be extended in the future.
Screenshots
CUI
PUI
ToDo: