Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Re-add playwright reporting #6992

Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Apr 10, 2024

This re-adds the playwright reporting now that I have figured out why it was flaks (report config section missing).

Discoverd during #6987

@matmair matmair added the CI CI / unit testing ecosystem label Apr 10, 2024
@matmair matmair added this to the 0.15.0 milestone Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 41c88fb
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66164b855dd752000803f0ff
😎 Deploy Preview https://deploy-preview-6992--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair matmair self-assigned this Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (77c8a9d) to head (41c88fb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6992   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files         875      875           
  Lines       40864    40864           
  Branches      283      283           
=======================================
  Hits        34426    34426           
  Misses       6365     6365           
  Partials       73       73           
Flag Coverage Δ
backend 85.44% <ø> (ø)
pui 49.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair marked this pull request as ready for review April 10, 2024 14:08
@matmair
Copy link
Member Author

matmair commented Apr 10, 2024

Ready for review and merge

@SchrodingersGat
Copy link
Member

@matmair LGTM

Will this help with the playwright issues I am seeing in #6970?

@SchrodingersGat SchrodingersGat merged commit 0d59f6e into inventree:master Apr 10, 2024
29 checks passed
@SchrodingersGat SchrodingersGat deleted the ci-readd-playwright-reporting branch April 10, 2024 15:00
@matmair
Copy link
Member Author

matmair commented Apr 10, 2024

Yer likely, you can download the HTML report after the tests fail an see in which state the UI was - this can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants