-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Use sessions backend for login #6399
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
netlify preview does not seem to want to login currently - is that expected? |
Seems like the CRSF stuff only works on the same domain, have to look deeper into it |
…matmair/issue6391
Have you set the What errors / feedback are you getting here? |
Seems to fix #5697 put I would like to see this confirmed after the demo server runs this version before closing that |
@matmair does not seem to work locally for me. I have pulled down the code, and running in a private browser session. Stuck at the "login" screen: The "token" request is being made correctly, and returns:
But none of these tokens get sent in the next request to And so the server rejects it of course: |
@matmair it seems that this approach does not let the user upload files? |
It seems to work localy but we would need to change CSRF to lax - not sure if it is worth it |
Can you expand on this? What adjustments would we need to make to CSRF? |
Replaced by #6970 |
Removes the usage of API tokens for PUI - switches to CSRF and session token.
Fixes #6391
Ref #5697