-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P_UI] Added django settings for p_ui #5343
[P_UI] Added django settings for p_ui #5343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@matmair Can you help me here with the remaining requests from your comments? |
✅ Deploy Preview for inventree ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Would be ready for merge from my POV, I added the translating commands to the netlify build process so that the ui previews correctly translated. |
@SchrodingersGat this would be ready for review and merge |
@SchrodingersGat just a gently ping on this pr. |
@wolflu05 thanks for the reminder :) Can you run me through how the settings get from If so, does this get rendered "live" by the server? What happens if the backend settings change? |
Yes, they get rendered into the index.html page accessible on the global window object.
Settings change in the config file/env variable requires a server restart until the new settings are available. Due to the implementation from @matmair the server list settings only get changed if they are not already saved in the local storage. So you need to clean your local storage until the new server list takes affect or use a new private tab for testing each time. |
Ok, happy with that. Thanks for getting this up and running :) |
This PR improves a few things: