Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PurchaseOrder Modal Form returns Server Error although responseCode is 200 #1984

Closed
Guusggg opened this issue Aug 20, 2021 · 4 comments · Fixed by #1997
Closed

Create PurchaseOrder Modal Form returns Server Error although responseCode is 200 #1984

Guusggg opened this issue Aug 20, 2021 · 4 comments · Fixed by #1997
Assignees
Labels
api Relates to the API bug Identifies a bug which needs to be addressed

Comments

@Guusggg
Copy link
Contributor

Guusggg commented Aug 20, 2021

Hi,

Today I encountered an issues when using the Multi Part Order functionality. When selecting multiple parts from a Supplier and clicking Order Parts, the modal for ordering several parts shows up. However, when clicking the little green + button to create a new Purchase Order, a dialog shows up that says

Error requesting form data
OK
Error Code - 200
Show Error Information

I looked a bit into it, and it seems the launchModalForm() function in modals.js expects to receive JSON to build the modal. However, looking into the console, it shows HTML so I think the URL wrongly sends HTML instead of JSON.

I currently do not have enough knowledge about the internals of the projects to fix this myself, however if someone can point me in the right direction I can do it!

Edit: I investigated some more and it seems all little green + buttons are affected, such as SupplierPart, PurchaseOrder, SalesOrder etc.

Any ideas?

Kind regards,

@eeintech
Copy link
Contributor

I can confirm it is broken 😕

I think Oliver wanted to convert all secondary modals to API forms so hopefully he will have time to take a look at what it takes to fix that one 😃

@eeintech eeintech added the bug Identifies a bug which needs to be addressed label Aug 20, 2021
@eeintech eeintech added the api Relates to the API label Aug 20, 2021
@SchrodingersGat
Copy link
Member

I've implemented a temporary fix for this one; a full refactor of the "order form wizard" will take considerably more effort.

@SchrodingersGat
Copy link
Member

@Guusggg please check that this error is remedied now

@Guusggg
Copy link
Contributor Author

Guusggg commented Aug 24, 2021

Sorry for the slow reaction but it's functioning great now! Thanks a lot!
@SchrodingersGat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API bug Identifies a bug which needs to be addressed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants