dependencies: Updates semantic-ui-react to latest #321
Conversation
| @@ -0,0 +1,11 @@ | |||
| import { createMedia } from '@artsy/fresnel'; | |||
|
|
|||
| export const AppMedia = createMedia({ | |||
There was a problem hiding this comment.
Nice! Was this suggested by Semantinc-UI?
There was a problem hiding this comment.
Yes, there is a "migration" guide -> Semantic-Org/Semantic-UI-React#4008
| @@ -70,7 +70,7 @@ export default class RelationModal extends Component { | |||
| size="large" | |||
| closeIcon | |||
| trigger={ | |||
| <> | |||
| <div> | |||
There was a problem hiding this comment.
is this div needed for spacing?
There was a problem hiding this comment.
No, it was changed because otherwise we get this error now
|
@jrcastro2 we might have to do the same in |
Yes, there are a couple of responsive elements in |
|
LGTM! did you check if the modals are working correctly ? |
Yes, they work correctly, we usually use the state of the component to store the open value of the modal so these breaking changes do not affect us. |
Updates SUI to the latest.
Breaking changes:
Responsiveelement is removed.Followed the migration advice -> Semantic-Org/Semantic-UI-React#4008