Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: wrong variable used #332

Closed
wants to merge 1 commit into from
Closed

bug: wrong variable used #332

wants to merge 1 commit into from

Conversation

carlinmack
Copy link

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

In all other tests with csv_excluded_fields and csv_included_fields, the comparison is made with the newly created new_key whereas here it is compared with parent_key and so this is most probably a bug

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack
Copy link
Author

we were mistaken!

@carlinmack carlinmack closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant