search: possibility to specify a different query_parser #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaiz
force-pushed
the
parser
branch
2 times, most recently
from
71ece1a to
5d68e82
Compare
This was referenced Dec 4, 2023
Closed
ntarocco
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Very nice, good job! Can you please update the docstring in the config.py and any other example that you can find in the repo (e.g. documentation)?
@kpsherva @sakshamarora1 this now (after release) could be used to remove the copy/pasted code of the entire search_factory in invenio-app-ils.
psaiz
force-pushed
the
parser
branch
2 times, most recently
from
028ad8b to
6851a83
Compare
|
Thanks @ntarocco. I've updated the config.py. Let me know if any other things should be done |
ntarocco
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Addresses #328