Add invenio GitHub

[alejandromumo]

closes inveniosoftware/invenio-github#98

[alejandromumo]

Tests are failing because invenio-github version is still the old one and has some old dependencies.

We need to:

• Merge Update invenio-webhook backend invenio-webhooks#65 ( invenio-webhooks)
• Release invenio-webhooks
• Bump invenio-webhooks in invenio-github(Refactor invenio-github backend invenio-github#98)
• Release Refactor invenio-github backend invenio-github#98
• Bump invenio-github in the current PR

[ppanero]

Very nice job! massive including the invenio-github PR. Could I ask you to transform the TODO into issues? we know TODO die burried in the code.

Needs tests 😇

[ppanero]

You mean validated before the process_release is called?

[alejandromumo]

Yes. Basically, I and @slint were discussing whether the public interface of GithubRelease should be just a publish method or also a process_release. But then we agreed that maybe the release "manager" (in this case in RDM) might want to do something before publishing the record - even though for now the release processing only publishes a record.

Conceptually, processing the release and publishing the record are distinct actions thus we separated them.

[ppanero]

This class seems to:

• Extract information from a release and create a dictionary of data via underscored methods (see comment below)
• Do record resolution manually, e.g. calls to PersistentIdentifiers and implement a pseudo resolver. Can we use existing resolvers/api classes?
• Process the release (missing validation?)
• Publish the release via rdm-records services

It seems to be a bit cluttered between an api class and a "service" (does not have to be a full fledge one, but split what's an object with information and data layer and what's management of it with service calls).

[alejandromumo]

Point-by-point replies:

1 - totally agree :)
2 - I ended up using PersistentIdentifier.get_by_object_uuid because we associate the record id (UUID) to the release as a weak reference to the record. Therefore, when we have a release with an associated record UUID, we can't use the PID resolver as it expects a pid_value and not object_uuid. I did not find any resolver for such a case but maybe I missed it
3 - see the reply below. This method is part of the public interface of invenio_github.api.GithubRelease and, in this case, simply calls the record publishing part. Which validation do you refer to?