utils: improve group create or update #343
Conversation
| else: | ||
| roles_ids.add(existing_role.id) | ||
|
|
||
| db.session.flush() # Ensure changes are written before committing |
There was a problem hiding this comment.
Isn't that happening eitherway on exit of db.session.begin_nested ?
There was a problem hiding this comment.
yes:
When the context manager yielded by Session.begin_nested() completes, it “commits” the savepoint, which includes the usual behavior of flushing all pending state. When an error is raised, the savepoint is rolled back and the state of the Session local to the objects that were changed is expired.
I am wondering if we should delegate to the caller to call this method inside the begin_nested, WDYT?
There was a problem hiding this comment.
I thought about this, however kept it here as it was the same behaviour as before. I will change it to be the caller 👍
EDIT: Actually moving it to the caller would not be possible because the for loop is inside this func and now we are creating SAVEPOINTS with the begin_nested for each value, plus the datastore.commit() is at the end of this func, it would imply calling this after every time we call this func which might be hard to remember
No description provided.