install: update flask version and fix build #57
Conversation
setup.py
Outdated
| @@ -35,7 +35,7 @@ | |||
| 'check-manifest>=0.25', | |||
| 'coverage>=4.0', | |||
| 'isort>=4.2.2', | |||
| 'jsonresolver[jsonschema]>=0.2.0', | |||
| 'jsonresolver[jsonschema]>=0.2.1', | |||
There was a problem hiding this comment.
Are you trying to fix the JSONSCHEMAS_HOST warning here? Because I don't think that this is the problem; The only dependency difference between a running build and a failed build is the version of Flask (compare https://travis-ci.org/inveniosoftware/invenio-jsonschemas/jobs/238764205#L259 and https://travis-ci.org/inveniosoftware/invenio-jsonschemas/jobs/238764224#L259).
There was a problem hiding this comment.
Yes indeed, I'll bump the flask version.
There was a problem hiding this comment.
Truth to be told, this is stumping me: I can't reproduce locally, even the logging on Travis is different (it looks like it's only printing stderr?)
There was a problem hiding this comment.
I can reproduce but the logging was not every time the same. It's strange.
nharraud
force-pushed
the
minor-fix
branch
2 times, most recently
from
544526f to
ad0ca5c
Compare
|
@jacquerie tests passed. Can you review and rebase your release PR on top of it? |
| 'jsonresolver[jsonschema]>=0.2.0', | ||
| 'pydocstyle>=1.0.0', | ||
| 'jsonresolver[jsonschema]>=0.2.1', | ||
| 'pydocstyle>=2.0.0', |
There was a problem hiding this comment.
Since you are able to reproduce: do we need these and...
There was a problem hiding this comment.
These are only test dependencies so I would rather update them as well.
There was a problem hiding this comment.
We had issues with pydocstyle in other modules (see inveniosoftware/troubleshooting#9). Having the last version will make the future failure more consistent between 'lowest' and 'release' builds.
| @@ -46,7 +46,7 @@ | |||
|
|
|||
| extras_require = { | |||
| 'docs': [ | |||
| 'Sphinx>=1.4.2', | |||
| 'Sphinx>=1.6.2', | |||
There was a problem hiding this comment.
Yes I got another issue with the previous version of sphinx. See sphinx-doc/sphinx#3212
Of course! I have a small question, otherwise for me this is good to go. |
* Update Flask version. * Fixes isort issue in a test file. * Fixes sphinx issue related to python 3 types refrences. (see https://bugs.python.org/issue11975) * Fixes sphinx build by updating to the last version. See sphinx-doc/sphinx#3212 Signed-off-by: Nicolas Harraudeau <[email protected]>
nharraud
changed the title
|
LGTM |
Fixes isort issue in a test file.
Fixes sphinx issue related to python 3 types refrences.
(see https://bugs.python.org/issue11975)
Signed-off-by: Nicolas Harraudeau [email protected]