UI update badges to new module #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennur
reviewed
Jul 19, 2023
invenio_github/templates/semantic-ui/invenio_github/helpers.html
Outdated
Show resolved
Hide resolved
invenio_github/templates/semantic-ui/invenio_github/helpers.html
Outdated
Show resolved
Hide resolved
slint
reviewed
Jul 19, 2023
anikachurilova
force-pushed
the
ui-update-badges-to-new-module
branch
from
4cde2d8 to
e61bc9f
Compare
zzacharo
approved these changes
Jul 21, 2023
zzacharo
reviewed
Jul 21, 2023
| @@ -6,28 +6,27 @@ | |||
| Invenio is free software; you can redistribute it and/or modify it | |||
| under the terms of the MIT License; see LICENSE file for more details. | |||
| #} | |||
| {%- macro doi_badge(doi, github_id, modal_name='') %} | |||
| {%- macro doi_badge(doi, doi_url, github_id) %} | |||
There was a problem hiding this comment.
our minds aligned here. We should try to use the central modal when we fix the doi to concept doi
zzacharo
approved these changes
Jul 21, 2023
* closes inveniosoftware#114
anikachurilova
force-pushed
the
ui-update-badges-to-new-module
branch
from
e61bc9f to
5f2b6e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: backend part commit is this #111, will be removed on its merge