app_factory: add init functions entry points #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this addition makes gives the opportunity to add finalize entry points to the create_api factory
utnapischtim
force-pushed
the
add-init-functions
branch
from
060458d to
3988082
Compare
slint
approved these changes
Jun 26, 2023
CHANGES.rst
Outdated
| @@ -8,6 +8,12 @@ | |||
| Changes | |||
| ======= | |||
|
|
|||
| Version 1.4.0 (released 2023-06-23) | |||
|
|
|||
| - Adds finalize_app and api_finalize_app entry points to the creation of the | |||
There was a problem hiding this comment.
Suggested change
| - Adds finalize_app and api_finalize_app entry points to the creation of the | |
| - Adds ``invenio_base.finalize_app`` and ``invenio_base.api_finalize_app`` entry points to the creation of the |
nit: for easier grepping in the future.
* every package which is used as an import statement should be added to the install requires explicitly * removed the upper limit from pytest-black. it is not necessary.
utnapischtim
force-pushed
the
add-init-functions
branch
from
3988082 to
5d99a1b
Compare
slint
force-pushed
the
add-init-functions
branch
from
5d99a1b to
e7ad584
Compare
slint
force-pushed
the
add-init-functions
branch
from
e7ad584 to
a98c3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before_(app_)first_requestdeprecation and removal in Flask v2.3 invenio-base#171