fix: before_first_request deprecation

[utnapischtim]

No description provided.

[slint]

LGTM, some naming things.

[slint]

minor: I would also keep the blueprint for backwards compat.

[utnapischtim]

i don't know how, because the variable doesn't exist anymore in settings.py. that was the reason to move the def login function into settings.py

[utnapischtim]

and to be clear, as i understand it is also not possible to create this variable here, because i would have to call create_settings_blueprint here at a time where the current_app is not accessible

[utnapischtim]

or should i do it that way, that i move the blueprint = Blueprint() outside of the create_settings_blueprint function?

[slint]

Suggested change

	def create_rest_blueprint(app):
	def create_blueprint(app):

nit: since we're in rest.py anyways and this is not exported anywhere

[utnapischtim]

my thinking was, that i don't have to add lines like
from invenio_accounts.views.settings import create_blueprint as create_settings_blueprint in conftest.py, because i have to import both there. And in my opinion it looks clearer in the setup.cfg file for the entrypoints

[slint]

Suggested change

	def post_ext_init(app):
	def set_default_config(app):

nit: to be more descriptive, and maybe add a docstring as well

[slint]

comment/question/shelve: wasn't it enough to just set this to None? If not maybe we should make it so, to make testing easier

[utnapischtim]

i tested it, and None is not enough because of following error message: AttributeError: 'NoneType' object has no attribute 'split'. i didn't tested if every variable has this problem, but to be consistent i would set all of them.